fix(ios): Xcode12 build run on device crash #70
Conversation
Since the ARTShadow structure holds a color object, it will cause a zombie object after destruction.
|
@lengmolehongyan I have failed to build your fix. Got couple of syntax errors. Is it verified solution you posted? |
Yeah, verified, would you mind uploading these build syntax errors? |
|
@lengmolehongyan Never mind, I made error during patch, that's why there was errors. Your fix seems to work fine for me. Thank you! |
|
I am facing with same issue. When it is planned to merge? |
|
The patch is good, but merging is blocked. Could anyone with write access approve the changes? Thanks. |
|
Can this update be released asap? |
|
Please release an update thanks |
|
I've tried to apply this patch and got malformed error, anyone else also had problems with it? @michbil maybe is the same problem that you had and solved next, is it? |
|
About the error above I just remove the '100%' on height sizes and worked well, the height prop looks support only numbers. |
|
Why has this still not been released as part of a new release? |
Summary
Fixing the issues outlined in #29721
Reason
Since the ARTShadow structure holds a color object, it will cause a zombie object after destruction.
Test Plan
Ran the example project
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist